Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PM-1726 Log invalid submissions #5

Merged
merged 1 commit into from
Jun 7, 2024
Merged

PM-1726 Log invalid submissions #5

merged 1 commit into from
Jun 7, 2024

Conversation

piotr-iohk
Copy link
Collaborator

Each stateless_verifier job will additionally print the list of submissions that don't pass the validation:

{"level":"info","ts":"2024-06-06T13:09:52.290+0200","logger":"Submission Updater","caller":"src/main.go:74","msg":"[INVALID] Submitter: B62qnZEWRGp4eRCzzpVRmEqA8wTPjKmm3NSzGNzxDww9yHHo9vnRdmc, Block hash: YKZsMkG2FHrqR3mPBv3wYsGJe5mMZHcDf6oQsC1Tu6G6Av5gcm, Submitted at: 2024-06-04 10:32:03 +0000 UTC, Validation error: Fail to decode block, Verified: true"}
{"level":"info","ts":"2024-06-06T13:09:52.290+0200","logger":"Submission Updater","caller":"src/main.go:74","msg":"[INVALID] Submitter: B62qnZEWRGp4eRCzzpVRmEqA8wTPjKmm3NSzGNzxDww9yHHo9vnRdmc, Block hash: YKZsMkG2FHrqR3mPBv3wYsGJe5mMZHcDf6oQsC1Tu6G6Av5gcm, Submitted at: 2024-06-04 21:13:25 +0000 UTC, Validation error: Fail to decode block, Verified: true"}
...

It can be easily filtered out in Grafana/Loki by INVALID keyword.

@piotr-iohk piotr-iohk self-assigned this Jun 7, 2024
simisimis
simisimis approved these changes Jun 7, 2024
View reviewed changes
Copy link
Collaborator

@simisimis simisimis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice addition! 👍

@piotr-iohk piotr-iohk merged commit 9596834 into main Jun 7, 2024
1 check passed
@piotr-iohk piotr-iohk deleted the print-invalid-subs branch June 7, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simisimis simisimis simisimis approved these changes

@michal0mina michal0mina Awaiting requested review from michal0mina

Assignees

@piotr-iohk piotr-iohk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piotr-iohk @simisimis